Added a MichaelComponent as per Project Sheet 1. <Do Not Merge Yet>#1
Open
mos2 wants to merge 6 commits into
Open
Added a MichaelComponent as per Project Sheet 1. <Do Not Merge Yet>#1mos2 wants to merge 6 commits into
mos2 wants to merge 6 commits into
Conversation
mos2
requested review from
CTeam30,
ChrisMurphy3,
ciaransheil,
ericm,
evilsmiley007 and
gal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone, this should not be merged - it is up to all of you students on the team to be the first to push up your work to GitHub.
I have added everyone as a reviewer on this Pull Request (PR) of my work, having followed the project sheet from Chris. Your end work should look something like this.
I have performed the work in a separate Git branch, called "michaels_work", which is separate to the "master" branch you have all been working in.
The PR view shows you what changes I have added (in green), and removed (in red) in my branch, compared to what is already in the "master" branch. You can also see the individual git commits that I made before opening this PR - the changes in each commit are included in the one PR.
This PR just shows you what it looks like to merge changes in a PR from one branch, back into the master. A code review is required by those who own/know the project code, and they decide if they want you to make any more changes/fixes before they agree to merge your code into the "master" branch.